Project

General

Profile

Actions

Feature #12234

closed

Want smbios battery support

Added by Robert Mustacchi almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

I have a system with an smbios battery entry and when I was looking at its smbios records with the illumos tools, I found that we didn't decode the smbios battery information so I went ahead and put that together.

With this in place, I can now decode it as follows (which has the same information as dmidecode):

$ smbios -t 22 ~/laptop.smbios 
ID    SIZE TYPE
42    53   SMB_TYPE_BATTERY (type 22) (portable battery)

  Manufacturer: SMP
  Product: 02DL005
  Location Tag: Front

  Battery Chemistry: 0x4 (Nickel Cadmium)
  Design Capacity: 51010 mWh
  Design Voltage: 15360 mV
  SBDS Version Number: 03.01
  Maximum Error: unknown
  SBDS Serial Number: 02bd
  SBDS Manufacture Date: 2019-07-11
  SBDS Device Chemistry: LiP
  OEM-specific Information: 0x00000000
Actions #1

Updated by Robert Mustacchi almost 4 years ago

To test this I also ran the smbios test suite against the new library:

$ LD_PRELOAD_32=/ws/rm/smbios/proto/root_i386/usr/lib/libsmbios.so.1 ./smbios 
TEST PASSED: slot tests
TEST PASSED: bad library version
TEST PASSED: memory device 3.2 / 3.2
TEST PASSED: memory device 3.2 / 3.3
TEST PASSED: memory device 3.3
TEST PASSED: memory device 3.3
TEST PASSED: processor additional information - amd64
TEST PASSED: processor additional information - riscv
TEST PASSED: processor additional information - bad table length 1
TEST PASSED: processor additional information - bad table length 2
TEST PASSED: processor additional information - bad table length 3
TEST PASSED: processor additional information - bad table length 4
TEST PASSED: processor additional information - bad type
Actions #2

Updated by Electric Monk almost 4 years ago

  • % Done changed from 90 to 100
  • Status changed from New to Closed

git commit 46782190b8c59b1b5fd7df81b2231ef50061fe2a

commit  46782190b8c59b1b5fd7df81b2231ef50061fe2a
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-01-31T19:49:19.000Z

    12234 Want smbios battery support
    Reviewed by: John Levon <john.levon@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF