Project

General

Profile

Actions

Bug #1224

closed

lp may overwrite constant data

Added by Rich Lowe almost 11 years ago. Updated almost 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2011-07-17
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

If built with -xstrconst or with gcc without -fwritable-strings lp will overwrite constant strings when:

1. Checking the terminfo database (type_letter in _isterminfo)
2. In numerous places while forming argument error messages
3. ... in countless places other places as yet undiscovered (yech!)

This bug covers #1 and #2. People playing along at home may wish to grep cmd/lp for any string constant assigned to char* and considering each of them deeply suspicious (though I suspect even a pass that thorough will miss the more insidious bits of this pile).

Actions #1

Updated by Rich Lowe almost 11 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 70 to 100

Resolved in r13410 commit:16832af22909

Actions

Also available in: Atom PDF