Project

General

Profile

Actions

Bug #12247

closed

vtinfo and vtdaemon are missing CTF data

Added by Jason King over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

For reasons I cannot remember, I noticed that /usr/lib/vtinfo and /usr/lib/vtdaemon do not get built with CTF data. While I'm not sure how much they get used, absent a specific reason not to, we should go ahead and build them with CTF data.

Actions #1

Updated by Jason King over 1 year ago

To test, I used wsdiff to compare the proto areas before and after this change, created an input file with the following contents:

usr/lib/vtinfo
usr/lib/vtdaemon

(I used an input file to minimize the noise in the results) then ran wsdiff -I inputfile -r /tmp/results proto.orig proto.

This resulted in the following, expected output:

# This file was produced by wsdiff
# 2020-01-23 at 21:37:56
Old proto area: proto.orig/
New proto area: proto/
Results file: /tmp/results

usr/lib/vtinfo
NOTE: ELF difference detected.

ELF sections found in proto/root_i386/usr/lib/vtinfo but not in proto.orig/root_i386/usr/lib/vtinfo

.SUNW_ctf

usr/lib/vtdaemon
NOTE: ELF difference detected.

ELF sections found in proto/root_i386/usr/lib/vtdaemon but not in proto.orig/root_i386/usr/lib/vtdaemon

.SUNW_ctf

Actions #2

Updated by Jason King over 1 year ago

I also ran ctfdump on the resulting two binaries and did a spot check to look for data, as well as entries for functions in vtdaemon (vtinfo only has a main() function so it's output while not empty, was pretty minimal which seems reasonable).

Actions #3

Updated by Electric Monk over 1 year ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 7093fd72e0be9a255aa4b1ed00a701f80699ac7d

commit  7093fd72e0be9a255aa4b1ed00a701f80699ac7d
Author: Jason King <jason.king@joyent.com>
Date:   2020-01-29T21:46:50.000Z

    12247 vtinfo and vtdaemon are missing CTF data
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF