Project

General

Profile

Actions
Copy link

Bug #12248

closed

libdscp no longer needs to link with libnsl

Added by Peter Tribble over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Peter Tribble
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:

Description

SPARC builds generate the following noise:

usr/platform/SUNW,SPARC-Enterprise/lib/fm/fmd/plugins/event-transport.so: unreferenced object=/export/home/ptribble/Illumos/2020-gate/proto/root_sparc/lib/libnsl.so.1; unused dependency of /export/home/ptribble/Illumos/2020-gate/proto/root_sparc/usr/platform/SUNW,SPARC-Enterprise/lib/libdscp.so.1 <remove lib or -zignore?>
usr/platform/SUNW,SPARC-Enterprise/lib/libdscp.so.1: unreferenced object=/export/home/ptribble/Illumos/2020-gate/proto/root_sparc/lib/libnsl.so.1; unused dependency of /export/home/ptribble/Illumos/2020-gate/proto/root_sparc/usr/platform/SUNW,SPARC-Enterprise/lib/libdscp.so.1 <remove lib or -zignore?>
usr/platform/SUNW,SPARC-Enterprise/sbin/prtdscp: unreferenced object=/export/home/ptribble/Illumos/2020-gate/proto/root_sparc/lib/libnsl.so.1; unused dependency of /export/home/ptribble/Illumos/2020-gate/proto/root_sparc/usr/platform/SUNW,SPARC-Enterprise/lib/libdscp.so.1 <remove lib or -zignore?>

This is because libdscp uses the functions inet_ntop and inet_pton, but these moved from libnsl to libc in #9673. Therefore, we no longer need to pull in libnsl.

Actions
Copy link
 #1

Updated by Electric Monk over 3 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit e90dc2b3580db8c2b04f138bba39aef292972dd2

commit  e90dc2b3580db8c2b04f138bba39aef292972dd2
Author: Peter Tribble <peter.tribble@gmail.com>
Date:   2020-01-25T19:10:20.000Z

    12248 libdscp no longer needs to link with libnsl
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions
Copy link

Also available in: Atom PDF