Project

General

Profile

Feature #12271

"name" member of "struct option" should be const

Added by Joshua M. Clulow 18 days ago. Updated 5 days ago.

Status:
New
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

In getopt.h we define struct option, which has a char *name member. On other platforms (e.g., modern Linux distributions, Mac OS X), this is actually const char *name. We should make our definition const as well, for better compatibility.

History

#1

Updated by Jonathan Perkin 10 days ago

I tested this in a bulk build.

Baseline: https://us-east.manta.joyent.com/pkgsrc/public/reports/upstream-bulktest/20200207.1853/meta/report.html
Patched: https://us-east.manta.joyent.com/pkgsrc/public/reports/upstream-bulktest/20200208.2201/meta/report.html

Executive summary is no regressions caused by the change, but it did fix one build (devel/kyua).

#2

Updated by Andy Fiddaman 7 days ago

hadfl has done a full OmniOS build with this fix in place, including all of the extra packages. No regressions.

#3

Updated by Joshua M. Clulow 7 days ago

  • Assignee set to Brian Bennett
#4

Updated by Michal Nowak 6 days ago

I'll see if I can rebuild OpenIndiana-specific components.

#5

Updated by Michal Nowak 5 days ago

Michal Nowak wrote:

I'll see if I can rebuild OpenIndiana-specific components.

I rebuilt a bunch of OI-specific components without a problem.

Also available in: Atom PDF