"name" member of "struct option" should be const
getopt.h we define
struct option, which has a
char *name member. On other platforms (e.g., modern Linux distributions, Mac OS X), this is actually
const char *name. We should make our definition
const as well, for better compatibility.
Updated by Jonathan Perkin over 2 years ago
I tested this in a bulk build.
Executive summary is no regressions caused by the change, but it did fix one build (devel/kyua).
Updated by Electric Monk over 2 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
commit b69c34dad3717624ff6b4f32b71014ee05b6a678 Author: Brian Bennett <firstname.lastname@example.org> Date: 2020-03-04T00:23:38.000Z 12271 "name" member of "struct option" should be const Reviewed by: Toomas Soome <email@example.com> Reviewed by: C Fraire <firstname.lastname@example.org> Reviewed by: Robert Mustacchi <email@example.com> Approved by: Dan McDonald <firstname.lastname@example.org>