Feature #12271
closed
"name" member of "struct option" should be const
Added by Joshua M. Clulow over 2 years ago.
Updated over 2 years ago.
Category:
lib - userland libraries
Description
In getopt.h
we define struct option
, which has a char *name
member. On other platforms (e.g., modern Linux distributions, Mac OS X), this is actually const char *name
. We should make our definition const
as well, for better compatibility.
hadfl has done a full OmniOS build with this fix in place, including all of the extra packages. No regressions.
- Assignee set to Brian Bennett
I'll see if I can rebuild OpenIndiana-specific components.
Michal Nowak wrote:
I'll see if I can rebuild OpenIndiana-specific components.
I rebuilt a bunch of OI-specific components without a problem.
In addition to testing provided by Joyent, OmniOS, and OpenIndiana, I built/installed/booted this build, where I discovered several utilities that also needed to be updated (also included in this patch).
- Status changed from New to Closed
- % Done changed from 0 to 100
git commit b69c34dad3717624ff6b4f32b71014ee05b6a678
commit b69c34dad3717624ff6b4f32b71014ee05b6a678
Author: Brian Bennett <brian.bennett@joyent.com>
Date: 2020-03-04T00:23:38.000Z
12271 "name" member of "struct option" should be const
Reviewed by: Toomas Soome <tsoome@me.com>
Reviewed by: C Fraire <cfraire@me.com>
Reviewed by: Robert Mustacchi <rm+illumos@fingolfin.org>
Approved by: Dan McDonald <danmcd@joyent.com>
Also available in: Atom
PDF