Project

General

Profile

Actions

Bug #12276

closed

smatch-clean sockfs

Added by Dan McDonald over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

While poking around sockfs for a customer, I found a bug by inspection. It wasn't a smatch-catchable bug, but I thought it was. So I cleaned up sockfs to be smatch-clean.

Actions #1

Updated by Dan McDonald over 1 year ago

Testing.

1.) Builds clean (and smatch-clean too).

2.) Did disassembly before/after. DEBUG diffs generate noise due to ASSERT line number changes. Non-DEBUG has differences in sodgram_direct and sostream_direct because I opted to not void out the always-returns-0 put procedures, but to instead return (*_*put()) and comment the put always returns 0.

3.) Applied patch to a SmartOS build and booted it on one of Kebecloud's CNs.

Actions #2

Updated by Rich Lowe over 1 year ago

  • Project changed from site to illumos gate
Actions #3

Updated by Electric Monk over 1 year ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 52aec5b9758f6352670ab269980b437a987f4822

commit  52aec5b9758f6352670ab269980b437a987f4822
Author: Dan McDonald <danmcd@joyent.com>
Date:   2020-02-08T21:55:35.000Z

    12276 smatch-clean sockfs
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Jason King <jason.king@joyent.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions

Also available in: Atom PDF