While poking around sockfs for a customer, I found a bug by inspection. It wasn't a smatch-catchable bug, but I thought it was. So I cleaned up sockfs to be smatch-clean.
Updated by Dan McDonald almost 2 years ago
1.) Builds clean (and smatch-clean too).
2.) Did disassembly before/after. DEBUG diffs generate noise due to ASSERT line number changes. Non-DEBUG has differences in sodgram_direct and sostream_direct because I opted to not void out the always-returns-0 put procedures, but to instead return (*_*put()) and comment the put always returns 0.
3.) Applied patch to a SmartOS build and booted it on one of Kebecloud's CNs.
Updated by Electric Monk almost 2 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
commit 52aec5b9758f6352670ab269980b437a987f4822 Author: Dan McDonald <email@example.com> Date: 2020-02-08T21:55:35.000Z 12276 smatch-clean sockfs Reviewed by: Toomas Soome <firstname.lastname@example.org> Reviewed by: Jason King <email@example.com> Approved by: Gordon Ross <firstname.lastname@example.org>