Project

General

Profile

Bug #12289

remove sunfire-specific code from libprtdiag

Added by Peter Tribble 10 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
IPD5
Gerrit CR:

Description

As part of IPD 5, support for sunfire (EXX00) will be removed. This will be split up to ease implementation and review.

This particular issue is to clean up libprtdiag and libprtdiag_psr.

The way that libprtdaig has been implemented on SPARC is that there are shared data structures passed around, and certain platforms fill in and reference the bits of those structures they need. Unfortunately, this means that definitions of sunfire-specific data structures are present in common code, so those need to be cleaned up in order for sunfire (and its header files) to be removed.

Not only are the data structures modified. but some are removed entirely, necessitating a modification of some internal function signatures.

#1

Updated by Peter Tribble 9 months ago

Review: https://www.illumos.org/rb/r/2513/

Testing: Copied the modified bits onto a T5140 and a Sun Blade 2000. Verified that prtdiag still functions and gives identical output.

#2

Updated by Electric Monk 9 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 2bcbf80ce6c8a2fb827428428c350ebe4f91f7ab

commit  2bcbf80ce6c8a2fb827428428c350ebe4f91f7ab
Author: Peter Tribble <peter.tribble@gmail.com>
Date:   2020-02-24T21:14:37.000Z

    12289 remove sunfire-specific code from libprtdiag
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF