Project

General

Profile

Bug #12294

rfs3_readdir()/rfs3_readdirplus(): Duplicate vattr_to_post_op_attr() call

Added by Marcel Telka 12 months ago. Updated 12 months ago.

Status:
Closed
Priority:
Low
Assignee:
Marcel Telka
Category:
nfs - NFS server and client
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

There are duplicate vattr_to_post_op_attr() calls at the end of rfs3_readdir() and rfs3_readdirplus(). The second one could be safely removed.

Related issues

Related to illumos gate - Feature #11083: support NFS server in zoneClosedDan McDonald

Actions
#1

Updated by Marcel Telka 12 months ago

#2

Updated by Marcel Telka 12 months ago

  • Priority changed from Normal to Low
#4

Updated by Marcel Telka 12 months ago

  • Status changed from In Progress to Pending RTI
#5

Updated by Dan McDonald 12 months ago

NOTE that "at the end" can be stated more specifically as "in sections that are essentially basic-blocks", namely the "out1:" goto labels of these two functions. There's no looping or other trickery than can make this happen. And the input parameter "vap" doesn't change over the course of this block, so the two calls are idempotent.

These duplicates were introduced by accident from the nfs-zone work (#11083).

#6

Updated by Electric Monk 12 months ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 0 to 100

git commit d5cb55e4df73e14ab5a6a4266b32230c8e73e54e

commit  d5cb55e4df73e14ab5a6a4266b32230c8e73e54e
Author: Marcel Telka <marcel@telka.sk>
Date:   2020-02-11T14:40:12.000Z

    12294 rfs3_readdir()/rfs3_readdirplus(): Duplicate vattr_to_post_op_attr() call
    Reviewed by: Vitaliy Gusev <gusev.vitaliy@icloud.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF