Bug #12294
rfs3_readdir()/rfs3_readdirplus(): Duplicate vattr_to_post_op_attr() call
Start date:
Due date:
% Done:
100%
Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
Description
There are duplicate vattr_to_post_op_attr() calls at the end of rfs3_readdir() and rfs3_readdirplus(). The second one could be safely removed.
Related issues
Updated by Marcel Telka about 1 year ago
- Related to Feature #11083: support NFS server in zone added
Updated by Dan McDonald about 1 year ago
NOTE that "at the end" can be stated more specifically as "in sections that are essentially basic-blocks", namely the "out1:" goto labels of these two functions. There's no looping or other trickery than can make this happen. And the input parameter "vap" doesn't change over the course of this block, so the two calls are idempotent.
These duplicates were introduced by accident from the nfs-zone work (#11083).
Updated by Electric Monk about 1 year ago
- Status changed from Pending RTI to Closed
- % Done changed from 0 to 100
git commit d5cb55e4df73e14ab5a6a4266b32230c8e73e54e
commit d5cb55e4df73e14ab5a6a4266b32230c8e73e54e
Author: Marcel Telka <marcel@telka.sk>
Date: 2020-02-11T14:40:12.000Z
12294 rfs3_readdir()/rfs3_readdirplus(): Duplicate vattr_to_post_op_attr() call
Reviewed by: Vitaliy Gusev <gusev.vitaliy@icloud.com>
Approved by: Dan McDonald <danmcd@joyent.com>