Project

General

Profile

Bug #12296

unix: access_mask_check() warn: bitwise AND condition is false here

Added by Toomas Soome 7 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

/code/illumos-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/smatch: ../../../common/acl/acl_common.c:879 access_mask_check() warn: bitwise AND condition is false here

the ACE_ACCESS_ALLOWED_ACE_TYPE is 0, therefore & operator makes little sense there, use == instead.

History

#1

Updated by Electric Monk 5 months ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit ef9416a894c90df5d46b888dbe2908c7f00fd409

commit  ef9416a894c90df5d46b888dbe2908c7f00fd409
Author: Toomas Soome <tsoome@me.com>
Date:   2020-05-01T06:43:40.000Z

    12296 unix: access_mask_check() warn: bitwise AND condition is false here
    Reviewed by: Matthias Scheler <mscheler@tintri.com>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Also available in: Atom PDF