illumos gate

Root cause

#11083 removed the required kmem_free() call.

Steps to reproduce

At server:

# share -o "iso8859-1=*" /tmp

At client:

# mount -o vers=3 SERVER:/tmp /mnt
# ls /mnt

Review: https://illumos.org/rb/r/2515/

Interesting, Dan you said that you did ::findleaks with no complaints?

(ick, pardon for the earlier accidental edits, @Vitaliy)

I did indeed try my best to squash leaks during #11083 testing... I never saw this leak. I notice the "iso8859-1" share option, though, and did NOT use that during my tests. I'm glad Marcel included this in the steps to reproduce.

A quick glance at the code, however, makes me wonder if this leak existed pre-nfs-zone. I'm going to attempt a reproduction on an older OmniOS for the record.

Dan McDonald wrote:

A quick glance at the code, however, makes me wonder if this leak existed pre-nfs-zone. I'm going to attempt a reproduction on an older OmniOS for the record.

Obviously, it didn't.

BTW, I'm keeping the `nfs-zone` branch of https://github.com/danmcd/illumos-gate/ around to see where problems like this happened.

One of the cherry-picks from illumos-nexenta was botched in the nfs-zone branch:

commit e98b6dbd8c259d0414f5519823d70023fd22d854
Author: Joyce McIntosh <joyce.mcintosh@nexenta.com>
Date:   Wed Apr 4 14:00:12 2018 -0600

   NEX-16712 NFS dtrace providers do not support per-share filtering

   Reviewed by: Evan Layton <evan.layton@nexenta.com>
   Reviewed by: Gordon Ross <gordon.ross@nexenta.com>
   Reviewed by: Yuri Pankon <yuri.pankov@nexenta.com>

There's merge problem where the merger also deleted a kmem_free() call. If you compare this with the original version of NEX-16712 in illumos-nexenta (commit 7e25247248cc565839a6ba3bab590094947437d5 in that repo) no kmem_free() calls were deleted in Joyce M's original. This problem was specific to the nfs-zone branch, and made it into #11083.