Project

General

Profile

Feature #12303

nfs/nfs4_drc.h: No such file or directory

Added by Andy Fiddaman 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Following 11083, any consumer of /usr/include/nfs/nfs4.h that has defined _KERNEL in order to access kernel data structures fails to compile due the absence of nfs/nfs4_drc.h

/usr/include/nfs/nfs4.h:43:10: fatal error: nfs/nfs4_drc.h: No such file or directory
   43 | #include <nfs/nfs4_drc.h>

(Yes, I'm looking at you lsof ..)

We should ship this additional header file, or do something else to allow these applications to continue building.


Related issues

Related to illumos gate - Feature #11083: support NFS server in zoneClosedDan McDonald

Actions
#1

Updated by Andy Fiddaman 10 months ago

#2

Updated by Marcel Telka 10 months ago

Just curious, how is this related to #11083?

#3

Updated by Vitaliy Gusev 10 months ago

Marcel Telka wrote:

Just curious, how is this related to #11083?

include <nfs/nfs4_drc.h> was added in that commit.

#4

Updated by Marcel Telka 10 months ago

Vitaliy Gusev wrote:

Marcel Telka wrote:

Just curious, how is this related to #11083?

include <nfs/nfs4_drc.h> was added in that commit.

I see. Thanks.

#5

Updated by Andy Fiddaman 10 months ago

  • Subject changed from Ship nfs4_drc.h to nfs/nfs4_drc.h: No such file or directory
#6

Updated by Andy Fiddaman 10 months ago

Simpler review posted at https://www.illumos.org/rb/r/2516/

wsdiff:

etc/versions/build
etc/motd
usr/sbin/isns
usr/sbin/iasl
usr/sbin/acpixtract
usr/sbin/acpidump
usr/lib/nfs/mountd
usr/lib/spell/hlistb
usr/lib/spell/hlista
usr/lib/amd64/libzpool.so.1
usr/lib/smbsrv/amd64/libfksmbsrv.so.1
usr/lib/smbsrv/libfksmbsrv.so.1
usr/lib/libc/libc_hwcap1.so.1
usr/lib/libc/libc_hwcap3.so.1
usr/lib/libc/libc_hwcap2.so.1
usr/lib/libzpool.so.1
usr/include/nfs/nfs4.h
lib/amd64/libc.so.1
lib/libc.so.1
opt/SUNWdtrt/tst/i386/ustack/tst.helper.exe
opt/SUNWdtrt/tst/i386/ustack/tst.annotated.exe
kernel/misc/amd64/nfs_dlboot
kernel/misc/amd64/nfssrv
kernel/fs/amd64/nfs
kernel/sys/amd64/nfs
platform/i86pc/kernel/amd64/unix
platform/i86xpv/kernel/amd64/unix

the nfs-related changes are:

usr/lib/nfs/mountd
NOTE: ELF .SUNW_dof difference detected.

153,154c153,154
< 0002300  \0   $   d   t   r   a   c   e   1   0   5   2   2   6   2   0
<         74642400 65636172 32353031 30323632
---
> 0002300  \0   $   d   t   r   a   c   e   1   0   5   2   0   7   6   4
>         74642400 65636172 32353031 34363730
167,170c167,170
< 0002460   a   t   a  \0   $   d   t   r   a   c   e   1   0   5   2   2
<         00617461 72746424 31656361 32323530
< 0002500   6   2   0   .   e   n   q   u   e   u   e   _   l   o   g   g
<         2e303236 75716e65 5f657565 67676f6c
---
> 0002460   a   t   a  \0   $   d   t   r   a   c   e   1   0   5   2   0
>         00617461 72746424 31656361 30323530
> 0002500   7   6   4   .   e   n   q   u   e   u   e   _   l   o   g   g
>         2e343637 75716e65 5f657565 67676f6c
177,180c177,180
< 0002600   a   t   a  \0   $   d   t   r   a   c   e   1   0   5   2   2
<         00617461 72746424 31656361 32323530
< 0002620   6   2   0   .   e   n   q   u   e   u   e   _   l   o   g   g
<         2e303236 75716e65 5f657565 67676f6c
---
> 0002600   a   t   a  \0   $   d   t   r   a   c   e   1   0   5   2   0
>         00617461 72746424 31656361 30323530
> 0002620   7   6   4   .   e   n   q   u   e   u   e   _   l   o   g   g
>         2e343637 75716e65 5f657565 67676f6c
187,188c187,188
< 0002720   e   1   0   5   2   2   6   2   0   .   m   o   u   n   t  \0
<         35303165 32363232 6f6d2e30 00746e75
---
> 0002720   e   1   0   5   2   0   7   6   4   .   m   o   u   n   t  \0
>         35303165 36373032 6f6d2e34 00746e75
195,196c195,196
< 0003020   1   0   5   2   2   6   2   0   .   d   o   _   l   o   g   g
<         32353031 30323632 5f6f642e 67676f6c
... etc.
usr/include/nfs/nfs4.h
NOTE: ASCII difference detected.

43d42
< #include <nfs/nfs4_drc.h>
810c809
<       rfs4_drc_t      *nfs4_drc;
---
>       struct rfs4_drc *nfs4_drc;

kernel/misc/amd64/nfs_dlboot
NOTE: ELF .strtab difference detected.

29,32c29,32
< 0000340   s  \0   i   n   i   t   _   d   o   n   e   .   3   2   1   2
<         6e690073 645f7469 2e656e6f 32313233
< 0000360   2  \0   i   n   i   t   _   n   e   t   b   u   f  \0   g   e
<         6e690032 6e5f7469 75627465 65670066
---
> 0000340   s  \0   i   n   i   t   _   d   o   n   e   .   3   2   0   8
>         6e690073 645f7469 2e656e6f 38303233
> 0000360   9  \0   i   n   i   t   _   n   e   t   b   u   f  \0   g   e
>         6e690039 6e5f7469 75627465 65670066
59,62c59,62
< 0000720   2   2   1   4  \0   c   a   c   h   e   i   n   f   o  \0   o
<         34313232 63616300 6e696568 6f006f66
< 0000740   n   c   e   _   o   n   l   y   .   3   2   2   3   2  \0   d
<         5f65636e 796c6e6f 3232332e 64003233
.. etc.
kernel/misc/amd64/nfssrv
NOTE: ELF .strtab difference detected.

133,134c133,134
< 0002040   .   2   9   3   4   5  \0   n   f   s   a   u   t   h   _   r
<         3339322e 6e003534 75617366 725f6874
---
> 0002040   .   2   9   3   1   2  \0   n   f   s   a   u   t   h   _   r
>         3339322e 6e003231 75617366 725f6874

kernel/fs/amd64/nfs
NOTE: ELF .strtab difference detected.

67,68c67,68
< 0001020   e   m   p   l   a   t   e   .   2   9   8   8   6  \0   n   f
<         6c706d65 2e657461 38383932 666e0036
---
> 0001020   e   m   p   l   a   t   e   .   2   9   8   5   3  \0   n   f
>         6c706d65 2e657461 35383932 666e0033
71,72c71,72
< 0001060   o   k   e   n   .   2   9   8   9   9  \0   n   f   s   _   d
<         6e656b6f 3839322e 6e003939 645f7366
etc.
#7

Updated by Andy Fiddaman 10 months ago

  • Description updated (diff)
#8

Updated by Electric Monk 10 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit 8b6e4188cd6fe49ddc2ff1e635b9c1538fbd5d48

commit  8b6e4188cd6fe49ddc2ff1e635b9c1538fbd5d48
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2020-02-14T22:58:25.000Z

    12303 nfs/nfs4_drc.h: No such file or directory
    Reviewed by: Marcel Telka <marcel@telka.sk>
    Reviewed by: Vitaliy Gusev <gusev.vitaliy@icloud.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF