crc16 implementations need disambiguation
While reviewing a BHYVE upstream today, I noticed this:
At least two crc16() implementations, and those are just the ones named "crc16".
Updated by Joshua M. Clulow about 1 month ago
If one were to collapse these into a single implementation, it would be good to first make sure they all produce the same output for every possible input. There are, as I recall, many different options for CRC routines; e.g., different polynomials, different initialisation vectors, etc.
Updated by Dan McDonald about 1 month ago
Wow. I thought crc16 was a single standard... nope:
Looks like there are 8 different "crc16" routines. Perhaps this bug should be re-summarized to perhaps say "crc16 implementations need name-level disambiguation"?