Project

General

Profile

Bug #12344

zpool iostat output formatting error

Added by Jerry Jelinek about 1 month ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

During the port from OpenZFS of:
dd50e0cc4c 11682 zpool iostat and status improvements

I missed a newline in the iostat output when displaying limited results for a top-level vdev only

[root@smartos ~]# zpool iostat zones c1t1d0
              capacity     operations     bandwidth 
vdev        alloc   free   read  write   read  write
----------  -----  -----  -----  -----  -----  -----
c1t1d0      13.4G  6.11G     16     41  1.68M   665K
----------  -----  -----  -----  -----  -----  -----[root@smartos ~]# 

I also missed the usage update describing this capability
[root@smartos ~]# zpool iostat -h
usage:
        iostat [[-lq]|[-rw]] [-T d | u] [-ghHLpPvy]
            [pool] ... [[-n] interval [count]]

History

#1

Updated by Jerry Jelinek about 1 month ago

  • Description updated (diff)
#2

Updated by Jerry Jelinek about 1 month ago

For testing, I did a zfs test suite run (although that doesn't catch these issues) to confirm there are no regressions. I also manually ran the variations of the iostat subcommand to visually confirm that the usage message now shows the vdev options and that it prints the separator correctly when specifying a vdev.

#3

Updated by Electric Monk about 1 month ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 20f5062b9c5143e4b4bd21245fcebdb21d40c08c

commit  20f5062b9c5143e4b4bd21245fcebdb21d40c08c
Author: Jerry Jelinek <jerry.jelinek@joyent.com>
Date:   2020-03-03T16:13:44.000Z

    12344 zpool iostat output formatting error
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Also available in: Atom PDF