Project

General

Profile

Actions

Bug #12362

closed

audio: buffer overflow

Added by Toomas Soome about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

smatch errors:

    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../common/io/audio/impl/audio_grc3.c:308 grc3_upsample_L() error: buffer overflow 'grc->history' 8192 <= 8192
    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../common/io/audio/impl/audio_grc3.c:308 grc3_dnsample_L() error: buffer overflow 'grc->history' 8192 <= 8192
    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../common/io/audio/impl/audio_grc3.c:309 grc3_upsample_M() error: buffer overflow 'grc->history' 8192 <= 8192
    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../common/io/audio/impl/audio_grc3.c:309 grc3_dnsample_M() error: buffer overflow 'grc->history' 8192 <= 8192
    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../common/io/audio/impl/audio_grc3.c:310 grc3_upsample_H() error: buffer overflow 'grc->history' 8192 <= 8192
    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../common/io/audio/impl/audio_grc3.c:310 grc3_dnsample_H() error: buffer overflow 'grc->history' 8192 <= 8192
    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../common/io/audio/impl/audio_grc3.c:311 grc3_upsample_HX() error: buffer overflow 'grc->history' 8192 <= 8192
    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../common/io/audio/impl/audio_grc3.c:311 grc3_dnsample_HX() error: buffer overflow 'grc->history' 8192 <= 8192
    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../common/io/audio/impl/audio_grc3.c:312 grc3_upsample_P() error: buffer overflow 'grc->history' 8192 <= 8192
    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../common/io/audio/impl/audio_grc3.c:312 grc3_dnsample_P() error: buffer overflow 'grc->history' 8192 <= 8192
    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../common/io/audio/impl/audio_grc3.c:313 grc3_upsample_PX() error: buffer overflow 'grc->history' 8192 <= 8192
    /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch: ../../common/io/audio/impl/audio_grc3.c:313 grc3_dnsample_PX() error: buffer overflow 'grc->history' 8192 <= 8192

Increase buffer size by one.

Actions #1

Updated by Electric Monk about 2 years ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit de172e901a45d2c11bb3be066bc4af11c104d52e

commit  de172e901a45d2c11bb3be066bc4af11c104d52e
Author: Toomas Soome <tsoome@me.com>
Date:   2020-04-29T16:15:05.000Z

    12362 audio: buffer overflow
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Garrett D'Amore <garrett@damore.org>

Actions

Also available in: Atom PDF