Project

General

Profile

Bug #12376

i86xpv/unix: 'rsdp' may be used uninitialized in this function

Added by Toomas Soome 9 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error with gcc 9:

    ../../i86pc/os/fakebop.c: In function 'build_firmware_properties':
    ../../i86pc/os/fakebop.c:2932:8: error: 'rsdp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
     2932 |   tp = find_fw_table(rsdp, ACPI_SIG_MCFG);
          |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cc1: all warnings being treated as errors

Testing done: build/install (I only do have i86pc).

Indeed, we are missing call to find_rsdp().

#1

Updated by Toomas Soome 9 months ago

  • Description updated (diff)
#2

Updated by Electric Monk 9 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 95bb2cef100e6d3ce201012b6e4b677106e44751

commit  95bb2cef100e6d3ce201012b6e4b677106e44751
Author: Toomas Soome <tsoome@me.com>
Date:   2020-03-12T15:34:10.000Z

    12376 i86xpv/unix: 'rsdp' may be used uninitialized in this function
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: John Levon <john.levon@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF