i86xpv/unix: 'rsdp' may be used uninitialized in this function
Build error with gcc 9:
../../i86pc/os/fakebop.c: In function 'build_firmware_properties': ../../i86pc/os/fakebop.c:2932:8: error: 'rsdp' may be used uninitialized in this function [-Werror=maybe-uninitialized] 2932 | tp = find_fw_table(rsdp, ACPI_SIG_MCFG); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors
Testing done: build/install (I only do have i86pc).
Indeed, we are missing call to find_rsdp().
Updated by Electric Monk over 1 year ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100
commit 95bb2cef100e6d3ce201012b6e4b677106e44751 Author: Toomas Soome <email@example.com> Date: 2020-03-12T15:34:10.000Z 12376 i86xpv/unix: 'rsdp' may be used uninitialized in this function Reviewed by: Andy Fiddaman <firstname.lastname@example.org> Reviewed by: John Levon <email@example.com> Approved by: Dan McDonald <firstname.lastname@example.org>