Project

General

Profile

Actions
Copy link

Bug #12396

closed

zdb -A does not work after 3006

Added by Yuri Pankov over 1 year ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Yuri Pankov
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
418

Description

Among other changes #3006 removed checks for aok value from ASSERT/VERIFY, so now specifying -A(AA) flags to zdb simply does nothing.

To test this, after updating to workspace contents, I have added explicit ASSERT(0) to dump_cachefile that gets called when -C is specified, and checked that zdb is now able to "bypass" that failed assertion:

callisto:yuri:~/ws/il12396/usr/src/cmd/zdb$ ./zdb -C
aok=0
zsh: segmentation fault (core dumped)  ./zdb -C
callisto:yuri:~/ws/il12396/usr/src/cmd/zdb$ ./zdb -AC
aok=1
ASSERTION CAUGHT: 0, file: zdb.c, line: 2638
data:
    version: 5000                                                                                                              name: 'data'
...other output...

Actions
Copy link
 #1

Updated by Electric Monk over 1 year ago

  • Gerrit CR set to 418
Actions
Copy link
 #2

Updated by Yuri Pankov about 2 months ago

  • Status changed from In Progress to Pending RTI
  • % Done changed from 10 to 90
Actions
Copy link
 #3

Updated by Yuri Pankov about 2 months ago

  • Description updated (diff)
Actions
Copy link
 #4

Updated by Electric Monk about 2 months ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 90 to 100

git commit 8e6f7903d5f7a53e1d6685962c900ab0f29c6b6c

commit  8e6f7903d5f7a53e1d6685962c900ab0f29c6b6c
Author: Yuri Pankov <ypankov@tintri.com>
Date:   2021-10-08T14:10:56.000Z

    12396 zdb -A does not work after 3006
    Reviewed by: Robert Mustacchi <rm+illumos@fingolfin.org>
    Reviewed by: Andy Fiddaman <andy@omnios.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF