Project

General

Profile

Actions

Bug #12397

closed

12254 broke the zfs test suite for older python versions

Added by Andrew Stormont over 1 year ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tests
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

On a machine with python 2.7.X the test suite now fails:

Test: /opt/zfs-tests/tests/functional/pool_checkpoint/checkpoint_big_rewind (run as root) [01:28] [PASS]
Traceback (most recent call last):
  File "/opt/test-runner/bin/run", line 923, in <module>
    main()
  File "/opt/test-runner/bin/run", line 917, in main
    testrun.run(options)
  File "/opt/test-runner/bin/run", line 750, in run
    self.testgroups[testgroup].run(self.logger, options)
  File "/opt/test-runner/bin/run", line 505, in run
    test.run(options)
  File "/opt/test-runner/bin/run", line 265, in run
    self.result.stdout, self.result.stderr = self.collect_output(proc)
  File "/opt/test-runner/bin/run", line 229, in collect_output
    fd.read()
  File "/opt/test-runner/bin/run", line 138, in read
    while self._read() is not None:
  File "/opt/test-runner/bin/run", line 150, in _read
    buf = os.read(fd, 4096).decode('utf-8')
  File "/usr/lib/python2.7/encodings/utf_8.py", line 16, in decode
    return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode byte 0xfd in position 12: invalid start byte

Related issues

Related to illumos gate - Bug #12254: python changes have broken the zfs test suiteClosed

Actions
Actions #1

Updated by Andrew Stormont over 1 year ago

  • Related to Bug #12254: python changes have broken the zfs test suite added
Actions #2

Updated by Andy Fiddaman 11 months ago

  • Category set to tests
  • Status changed from New to In Progress
  • Assignee set to Andy Fiddaman
Actions #3

Updated by Andy Fiddaman 11 months ago

I tested the change in the attached Gerrit review by running the ZFS test suite under python 2.7, 3.7 and 3.9.
It no longer fails with this exception whereas it did before.

Actions #4

Updated by Andrew Stormont 11 months ago

It still seems to fail for me:

Test: /opt/zfs-tests/tests/functional/pool_checkpoint/checkpoint_big_rewind (run as root) [02:13] [PASS]
Traceback (most recent call last):
  File "/opt/test-runner/bin/run", line 924, in <module>
    main()
  File "/opt/test-runner/bin/run", line 918, in main
    testrun.run(options)
  File "/opt/test-runner/bin/run", line 751, in run
    self.testgroups[testgroup].run(self.logger, options)
  File "/opt/test-runner/bin/run", line 506, in run
    test.run(options)
  File "/opt/test-runner/bin/run", line 266, in run
    self.result.stdout, self.result.stderr = self.collect_output(proc)
  File "/opt/test-runner/bin/run", line 230, in collect_output
    fd.read()
  File "/opt/test-runner/bin/run", line 139, in read
    while self._read() is not None:
  File "/opt/test-runner/bin/run", line 151, in _read
    buf = os.read(fd, 4096).decode('utf-8')
  File "/usr/lib/python2.7/encodings/utf_8.py", line 16, in decode
    return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode byte 0xce in position 11: invalid continuation byte

Actions #5

Updated by Andy Fiddaman 11 months ago

  • Gerrit CR set to 1102
Actions #6

Updated by Andy Fiddaman 11 months ago

You don't seem to have the proposed patch from https://code.illumos.org/c/illumos-gate/+/1102

Actions #7

Updated by Electric Monk 10 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit cc37296fa5ddc1ddd4012e040f797164c2a5cf5d

commit  cc37296fa5ddc1ddd4012e040f797164c2a5cf5d
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2020-12-16T14:18:06.000Z

    13358 dmu_objset_upgrade_stop() needs to wait
    12397 12254 broke the zfs test suite for older python versions
    Portions contributed by: Tom Caputi <tcaputi@datto.com>
    Portions contributed by: Nasf-Fan <fan.yong@intel.com>
    Portions contributed by: Gvozden Neskovic <neskovic@gmail.com>
    Reviewed by: Jason King <jason.king@joyent.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF