Project

General

Profile

Actions
Copy link

Bug #12399

closed

kobj printf functions should be checked

Added by John Levon over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
John Levon
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

They're not marked as printflike, but they should be.

Actions
Copy link
 #1

Updated by John Levon over 2 years ago

Tested this with a verbose boot and checked that the output looked good, including the initial bug output that prompted this fix.

Actions
Copy link
 #2

Updated by John Levon over 2 years ago

Specifically, the output of "buf" value in kobj_read_file() was not wide enough for the 64-bit pointer

Actions
Copy link
 #3

Updated by Electric Monk over 2 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit c61137df0ddfe2318cd4b953495b4ccdb8f12b61

commit  c61137df0ddfe2318cd4b953495b4ccdb8f12b61
Author: John Levon <john.levon@joyent.com>
Date:   2020-03-23T16:07:34.000Z

    12399 kobj printf functions should be checked
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF