Project

General

Profile

Actions

Bug #12419

closed

intel_nb5000: variable may be used uninitialized

Added by Toomas Soome about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build errors with gcc 9:

    ../../intel/io/intel_nb5000/intel_nb5000.c: In function 'nf_memory_error':
    ../../intel/io/intel_nb5000/intel_nb5000.c:285:24: error: 'recmemb' may be used uninitialized in this function [-Werror=maybe-uninitialized]
      285 |     sp->cas = (recmemb >> 16) & CAS_MASK;
          |               ~~~~~~~~~^~~~~~
    ../../intel/io/intel_nb5000/intel_nb5000.c: In function 'nb_drain':
    ../../intel/io/intel_nb5000/intel_nb5000.c:2212:4: error: 'scr_eqep' may be used uninitialized in this function [-Werror=maybe-uninitialized]
     2212 |    errorq_cancel(ereport_errorq, scr_eqep);
          |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../../intel/io/intel_nb5000/intel_nb5000.c:2210:3: error: 'eqep' may be used uninitialized in this function [-Werror=maybe-uninitialized]
     2210 |   errorq_commit(ereport_errorq, eqep, ERRORQ_SYNC);
          |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cc1: all warnings being treated as errors

Testing done: build/install/boot

Actions #1

Updated by Electric Monk almost 2 years ago

  • Gerrit CR set to 438
Actions #2

Updated by Toomas Soome almost 2 years ago

  • Description updated (diff)
Actions #3

Updated by Electric Monk almost 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 1a10a9077a9effc574b7f797a4d321dd0cea4197

commit  1a10a9077a9effc574b7f797a4d321dd0cea4197
Author: Toomas Soome <tsoome@me.com>
Date:   2020-08-05T14:13:03.000Z

    12419 intel_nb5000: variable may be used uninitialized
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF