Project

General

Profile

Bug #12420

fd: variable may be used uninitialized

Added by Toomas Soome 9 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build errors with gcc 9:

    ../../common/io/fd.c: In function 'fdgetlabel':
    ../../common/io/fd.c:871:5: error: 'rval' may be used uninitialized in this function [-Werror=maybe-uninitialized]
      871 |  if (rval) {
          |     ^
    cc1: all warnings being treated as errors

Testing done: build/install/boot

#1

Updated by Toomas Soome 9 months ago

  • Description updated (diff)
#2

Updated by Electric Monk 8 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit d1d0a29b5275e074d59d170cca23b45a6e5834d8

commit  d1d0a29b5275e074d59d170cca23b45a6e5834d8
Author: Toomas Soome <tsoome@me.com>
Date:   2020-03-23T16:20:13.000Z

    12420 fd: variable may be used uninitialized
    Reviewed by: Yuri Pankov <ypankov@fastmail.com>
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF