Project

General

Profile

Bug #12424

openeepr: variable may be used uninitialized

Added by Toomas Soome 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build errors with gcc 9:

    ../../common/io/openprom.c -mcmodel=kernel
    ../../common/io/openprom.c: In function 'opromioctl_cb':
    ../../common/io/openprom.c:609:20: error: 'node_id' may be used uninitialized in this function [-Werror=maybe-uninitialized]
      609 |   valbuf = (char *)prom_nextprop(node_id, opp->oprom_array,
          |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      610 |       propname);
          |       ~~~~~~~~~
    cc1: all warnings being treated as errors

#1

Updated by Electric Monk 8 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit eefd1fd8cdcbc3b47ccbc8e3609736f4e94ec70f

commit  eefd1fd8cdcbc3b47ccbc8e3609736f4e94ec70f
Author: Toomas Soome <tsoome@me.com>
Date:   2020-04-16T04:58:28.000Z

    12424 openeepr: variable may be used uninitialized
    Reviewed by: Richard Lowe <richlowe@richlowe.net>
    Reviewed by: Gary Mills <gary_mills@fastmail.fm>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF