Project

General

Profile

Bug #12432

vntsd: NULL pointer errors

Added by Toomas Soome 9 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with NULL pointer on SPARC:

    write.c: In function 'write_one_client':
    write.c:201: error: passing argument 2 of 'thr_kill' makes integer from pointer without a cast
    /code/illumos-gate/proto/root_sparc/usr/include/thread.h:81: note: expected 'int' but argument is of type 'void *'

    /code/illumos-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/smatch: vntsdvcc.c:462 alloc_cons_with_group() warn: variable dereferenced before check 'new_groupp' (see line 382)

    /code/illumos-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/smatch: vntsd.c:361 main() warn: double check that we're allocating correct size: 92 vs 1

    read.c: In function 'vntsd_read':
    read.c:287: error: return makes integer from pointer without a cast

    console.c: In function 'create_write_thread':
    console.c:115: error: passing argument 5 of 'thr_create' makes integer from pointer without a cast
    /code/illumos-gate/proto/root_sparc/usr/include/thread.h:54: note: expected 'long int' but argument is of type 'void *'

#1

Updated by Electric Monk 8 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 476d5ff73c235a63ab06a9852e510910a3ce1793

commit  476d5ff73c235a63ab06a9852e510910a3ce1793
Author: Toomas Soome <tsoome@me.com>
Date:   2020-04-02T06:53:35.000Z

    12432 vntsd: NULL pointer errors
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF