Project

General

Profile

Bug #12440

mlxcx should not block in the send path

Added by Paul Winder 9 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The driver will cv_wait() in the send path when it is short of resources - buffers or ring space.

It shouldn't block, it should rather let mac know by returning the mblk passed in.


Related issues

Related to illumos gate - Bug #12383: Slow down and lock up in mlxcx receive interrupt pathClosedPaul Winder

Actions
#1

Updated by Paul Winder 9 months ago

  • Category set to driver - device drivers
  • Status changed from New to In Progress
  • Assignee set to Paul Winder
  • % Done changed from 0 to 80
#2

Updated by Paul Winder 8 months ago

  • Related to Bug #12383: Slow down and lock up in mlxcx receive interrupt path added
#3

Updated by Electric Monk 8 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 80 to 100

git commit 22d052287ba7ed169757650e2eec25fedbae163a

commit  22d052287ba7ed169757650e2eec25fedbae163a
Author: Paul Winder <pwinder@racktopsystems.com>
Date:   2020-04-14T15:40:07.000Z

    12383 Slow down and lock up in mlxcx receive interrupt path
    12438 mlxcx should pass receive messages to mac layer more frequently
    12439 mlxcx send rings can overflow
    12440 mlxcx should not block in the send path
    12441 mlxcx default queue sizes are a bit on the small size
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Garrett D'Amore <garrett@damore.org>

Also available in: Atom PDF