Project

General

Profile

Bug #12461

krtld: printf format errors

Added by Toomas Soome 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors on SPARC after 12399:

    ../../sparc/krtld/doreloc.c: In function 'do_reloc_krtld':
    ../../sparc/krtld/doreloc.c:471: error: format '%llx' expects type 'long long unsigne
    d int', but argument 3 has type 'long unsigned int' [-Wformat]
    ../../sparc/krtld/doreloc.c:537: error: format '%llx' expects type 'long long unsigne
    d int', but argument 3 has type 'Xword' [-Wformat]
    ../../sparc/krtld/doreloc.c:537: error: format '%llx' expects type 'long long unsigne
    d int', but argument 3 has type 'long unsigned int' [-Wformat]

    ../../sparc/krtld/kobj_reloc.c: In function 'do_relocate':
    ../../sparc/krtld/kobj_reloc.c:210: error: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'long int' [-Wformat]
    ../../sparc/krtld/kobj_reloc.c: In function 'do_relocations':
    ../../sparc/krtld/kobj_reloc.c:356: error: format '%lld' expects type 'long long int', but argument 3 has type 'uint_t' [-Wformat]

Debug build:
   ../../sparc/krtld/kobj_reloc.c: In function 'do_relocate':
    ../../sparc/krtld/kobj_reloc.c:226: error: format '%8llx' expects type 'long long unsigned int', but argument 3 has type 'long int' [-Wformat]
    ../../sparc/krtld/kobj_reloc.c:227: error: format '%8llx' expects type 'long long unsigned int', but argument 3 has type 'Elf64_Sxword' [-Wformat]
    ../../sparc/krtld/kobj_reloc.c:312: error: format '%8llx' expects type 'long long unsigned int', but argument 3 has type 'long int' [-Wformat]
    ../../sparc/krtld/kobj_reloc.c:313: error: format '%8llx' expects type 'long long unsigned int', but argument 3 has type 'Addr' [-Wformat]

#1

Updated by Toomas Soome 8 months ago

  • Description updated (diff)
#2

Updated by Electric Monk 8 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 4859da614b562d26b86cd0961067070cb5ed350c

commit  4859da614b562d26b86cd0961067070cb5ed350c
Author: Toomas Soome <tsoome@me.com>
Date:   2020-04-06T06:14:06.000Z

    12461 krtld: printf format errors
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: John Levon <john.levon@joyent.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Also available in: Atom PDF