Project

General

Profile

Bug #12464

fix kmdb build

Added by John Levon 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

With a newer build host, it revealed that we were not compiling kmdb properly post removal of 32-bit kdi_regs.h

#1

Updated by John Levon 8 months ago

The problem was that I tested on a system where ia32/kdi_regs.h still existed on the host system, so we picked up that.

When it's gone, we need kdi_regs.h to be the 64-bit version. This has consequences for code in mdb/ that still tries to do KVM-ish things for 32-bit case. As a result we need to remove mdb_ia32util.c - and move the small bits still existing there into its only user, proc_ia32dep.c

This also now makes mdb_isautil.h redundant.

#2

Updated by Electric Monk 8 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 3afb2a2ae94e9183977495f0d248b766e58e4016

commit  3afb2a2ae94e9183977495f0d248b766e58e4016
Author: John Levon <john.levon@joyent.com>
Date:   2020-04-03T15:05:41.000Z

    12464 fix kmdb build
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Also available in: Atom PDF