Project

General

Profile

Bug #12467

Add support for AMD PPIN

Added by Robert Mustacchi 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

In 9747 we added support for Intel's PPIN feature to facilitate the use of CPU auto-replace. AMD added support for that. This generalizes the previous implementation to add support for AMD.

To test this, I ran this on and AMD system with a Rome chip and found that PPIN works and I had a serial number on the processor node in topo.


Related issues

Related to illumos gate - Feature #9747: Implement CPU autoreplace based on Intel PPINClosedRobert Mustacchi2018-08-16

Actions
#1

Updated by Robert Mustacchi 8 months ago

  • Related to Feature #9747: Implement CPU autoreplace based on Intel PPIN added
#2

Updated by Robert Mustacchi 8 months ago

To test this, we booted this in three different situations:

  • With an AMD EPYC Rome CPU that has access to ppin.
  • With an Intel Ivy Bridge (thanks Patrick!) Xeon that verified the PPIN support still worked on Intel.
  • With a VM that didn't expose PPIN to verify that systems without it still worked just fine.

Here's an example of the output from an AMD system:

...
hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0
  group: protocol                       version: 1   stability: Private/Private
    resource          fmri      hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0
    FRU               fmri      hc://:server-id=beowulf:serial=iv0-AMD-830f10-1f0ef44db000088/motherboard=0/chip=0
  group: authority                      version: 1   stability: Private/Private
    server-id         string    beowulf
  group: chip-properties                version: 1   stability: Private/Private
    vendor_id         string    AuthenticAMD
    family            int32     23
    model             int32     49
    stepping          int32     0
    brand             string    AMD EPYC 7282 16-Core Processor
...
#3

Updated by Electric Monk 8 months ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit a47ab03e261661b7326ab0b642649034886be632

commit  a47ab03e261661b7326ab0b642649034886be632
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-04-06T15:01:37.000Z

    12467 Add support for AMD PPIN
    12468 Remove generic_cpu -Wno-parentheses gag
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Yuri Pankov <ypankov@fastmail.com>
    Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF