Project

General

Profile

Bug #12489

fmtopo needs more precise handling of arguments to -P

Added by Rob Johnston 3 months ago. Updated 3 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

fmtopo allows one to manipulate LED states by setting the value of the mode property on the corresponding indicator facility node by invoking fmtopo as follows:

fmtopo -P property_group.property=type:value <fmri_pattern>

for example:

fmtopo -P facility.mode=uint32:1 "*ses-enclosure=1/bay=10?indicator=fail" 

We saw a case in SPC where an operator copied and pasted an fmtopo command line example and somehow a control character was included between the argument -P and the <fmri_pattern>, which causes everything after -P to be interpreted as the operand. As a result, fmtopo behaved as if there were no fmri pattern to filter which nodes to act on and so applied the change to all nodes.

fmtopo's parsing here needs to be smarter.

History

#1

Updated by Rob Johnston 3 months ago

  • Description updated (diff)

Also available in: Atom PDF