Project

General

Profile

Bug #12505

Answer KEBE question about cred in unexport()

Added by Dan McDonald 3 months ago. Updated 3 months ago.

Status:
New
Priority:
Normal
Assignee:
Category:
nfs - NFS server and client
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

There are two /* XXX KEBE */ comments in illumos-gate that arrived with the nfs-zone push. One is easy to just remove. The other, in unexport(), asks a question worth investigating:

        /*                                                                      
         * XXX KEBE ASKS --> Should CRED() instead be                           
         * exi->exi_zone->zone_kcred?                                           
         */
        if (exi == ne->exi_public) {
                ne->exi_public = ne->exi_root;

                nfslog_share_record(ne->exi_public, CRED());
        }

Files

12505.patch (2.01 KB) 12505.patch Dan McDonald, 2020-04-15 05:33 PM

Related issues

Related to illumos gate - Feature #11083: support NFS server in zoneClosed

Actions
Related to illumos gate - Bug #12278: nfs-zone needs man page changesClosed

Actions

History

#1

Updated by Marcel Telka 3 months ago

#2

Updated by Dan McDonald 3 months ago

  • Related to Bug #12278: nfs-zone needs man page changes added
#3

Updated by Dan McDonald 3 months ago

I apologize for leaving KEBE comments in illumos-gate. They are my own notation, and are supposed to be removed prior to any push.

#4

Updated by Vitaliy Gusev 3 months ago

Dan McDonald wrote:

I apologize for leaving KEBE comments in illumos-gate. They are my own notation, and are supposed to be removed prior to any push.

It can be removed by coming nfs4.1 code.

#5

Updated by Dan McDonald 3 months ago

Vitaliy Gusev wrote:

Dan McDonald wrote:

I apologize for leaving KEBE comments in illumos-gate. They are my own notation, and are supposed to be removed prior to any push.

It can be removed by coming nfs4.1 code.

I have a fix coming for review very soon. Easy enough to test and review.

#6

Updated by Yuri Pankov 3 months ago

Vitaliy Gusev wrote:

Dan McDonald wrote:

I apologize for leaving KEBE comments in illumos-gate. They are my own notation, and are supposed to be removed prior to any push.

It can be removed by coming nfs4.1 code.

Coming when/where from?

#7

Updated by Dan McDonald 3 months ago

Yuri Pankov wrote:

Coming when/where from?

I was hoping for testing later this week, but I'll have to punt to next. Attaching my first-cut patch.

Also available in: Atom PDF