Project

General

Profile

Actions

Bug #12524

closed

fm: unsigned is never less than zero

Added by Toomas Soome about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build error on SPARC:

    chip_sun4v.c: In function 'chip_create':
    chip_sun4v.c:356: error: comparison of unsigned expression < 0 is always false [-Wtype-limits]
    chip_sun4v.c:356: error: comparison of unsigned expression < 0 is always false [-Wtype-limits]
    /code/illumos-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/smatch: chip_sun4v.c:356 chip_create() warn: unsigned 'max' is never less than zero.

    hb_sun4v.c: In function 'platform_hb_enum':
    hb_sun4v.c:294: error: comparison of unsigned expression < 0 is always false [-Wtype-limits]
    hb_sun4v.c:294: error: comparison of unsigned expression < 0 is always false [-Wtype-limits]
    /code/illumos-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/smatch: hb_sun4v.c:294 platform_hb_enum() warn: unsigned 'imax' is never less than zero.

Actions #1

Updated by Electric Monk about 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 745679391d7a234b12343aa2407c382709f6d4bd

commit  745679391d7a234b12343aa2407c382709f6d4bd
Author: Toomas Soome <tsoome@me.com>
Date:   2020-04-19T19:39:22.000Z

    12524 fm: unsigned is never less than zero
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF