Project

General

Profile

Actions

Bug #12545

closed

ixgbe: IXGBE_LE32_TO_CPUS macro is missing assignment

Added by Toomas Soome about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with NULL pointer:

    cc1: warnings being treated as errors
    ../../common/io/ixgbe/core/ixgbe_common.c: In function 'ixgbe_host_interface_command':
    ../../common/io/ixgbe/core/ixgbe_common.c:4623: error: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    ../../common/io/ixgbe/core/ixgbe_common.c:4623: error: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    ../../common/io/ixgbe/core/ixgbe_common.c:4623: error: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    ../../common/io/ixgbe/core/ixgbe_common.c:4623: error: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    ../../common/io/ixgbe/core/ixgbe_common.c:4635: error: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    ../../common/io/ixgbe/core/ixgbe_common.c:4635: error: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    ../../common/io/ixgbe/core/ixgbe_common.c:4635: error: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    ../../common/io/ixgbe/core/ixgbe_common.c:4635: error: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    ../../common/io/ixgbe/core/ixgbe_common.c:4658: error: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    ../../common/io/ixgbe/core/ixgbe_common.c:4658: error: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    ../../common/io/ixgbe/core/ixgbe_common.c:4658: error: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    ../../common/io/ixgbe/core/ixgbe_common.c:4658: error: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    *** Error code 1
    dmake: Warning: Command failed for target `obj64/ixgbe_common.o'
    Current working directory /code/illumos-gate/usr/src/uts/sparc/ixgbe

It turns out the macro is missing the assignment to store the byteswap.

Actions #1

Updated by Toomas Soome almost 2 years ago

  • Subject changed from ixgbe: NULL pointer errors to ixgbe: IXGBE_LE32_TO_CPUS macro is missing assignment
  • Description updated (diff)
Actions #2

Updated by Electric Monk almost 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit e213fe2d75a0e47cc0b3f67c473e24dfa9304e0b

commit  e213fe2d75a0e47cc0b3f67c473e24dfa9304e0b
Author: Toomas Soome <tsoome@me.com>
Date:   2020-06-01T14:33:16.000Z

    12545 ixgbe: IXGBE_LE32_TO_CPUS macro is missing assignment
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF