Project

General

Profile

Actions

Bug #12547

closed

pci_pci: NULL pointer errors

Added by Toomas Soome about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with NULL pointer:

    cc1: warnings being treated as errors
    ../../sun4u/io/pci/pcix.c: In function 'pcix_set_cmd_reg':
    ../../sun4u/io/pci/pcix.c:68: error: passing argument 3 of 'pci_cap_get' makes integer from pointer without a cast
    ../../common/sys/pci_cap.h:110: note: expected 'uint32_t' but argument is of type 'void *'
    ../../sun4u/io/pci/pcix.c:81: error: passing argument 3 of 'pci_cap_put' makes integer from pointer without a cast
    ../../common/sys/pci_cap.h:113: note: expected 'uint32_t' but argument is of type 'void *'

    cc1: warnings being treated as errors
    ../../sun4u/io/pci/pci_pci.c: In function 'ppb_pwr_setup':
    ../../sun4u/io/pci/pci_pci.c:1079: error: passing argument 3 of 'pci_cap_get' makes integer from pointer without a cast
    ../../common/sys/pci_cap.h:110: note: expected 'uint32_t' but argument is of type 'void *'
    ../../sun4u/io/pci/pci_pci.c:1082: error: passing argument 3 of 'pci_cap_get' makes integer from pointer without a cast
    ../../common/sys/pci_cap.h:110: note: expected 'uint32_t' but argument is of type 'void *'
    ../../sun4u/io/pci/pci_pci.c:1168: error: passing argument 6 of 'ddi_prop_create' makes integer from pointer without a cast
    ../../common/sys/sunddi.h:944: note: expected 'int' but argument is of type 'void *'
    ../../sun4u/io/pci/pci_pci.c: In function 'pci_pwr_current_lvl':
    ../../sun4u/io/pci/pci_pci.c:1242: error: passing argument 3 of 'pci_cap_get' makes integer from pointer without a cast
    ../../common/sys/pci_cap.h:110: note: expected 'uint32_t' but argument is of type 'void *'
    ../../sun4u/io/pci/pci_pci.c: In function 'ppb_pwr':
    ../../sun4u/io/pci/pci_pci.c:1319: error: passing argument 3 of 'pci_cap_get' makes integer from pointer without a cast
    ../../common/sys/pci_cap.h:110: note: expected 'uint32_t' but argument is of type 'void *'
    ../../sun4u/io/pci/pci_pci.c:1406: error: passing argument 3 of 'pci_cap_put' makes integer from pointer without a cast
    ../../common/sys/pci_cap.h:113: note: expected 'uint32_t' but argument is of type 'void *'
    *** Error code 1
    dmake: Warning: Command failed for target `obj64/pci_pci.o'
    Current working directory /code/illumos-gate/usr/src/uts/sparc/pci_pci

Actions #1

Updated by Electric Monk about 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 9d9483ac38cb12576b0b6e2a6d950e6d65a622a0

commit  9d9483ac38cb12576b0b6e2a6d950e6d65a622a0
Author: Toomas Soome <tsoome@me.com>
Date:   2020-04-24T18:12:34.000Z

    12547 pci_pci: NULL pointer errors
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF