Project

General

Profile

Actions

Bug #12555

closed

pcicfg: NULL pointer errors

Added by Toomas Soome about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with NULL pointer:

    cc1: warnings being treated as errors
    ../../sun4/io/pcicfg.c: In function 'pcicfg_get_nslots':
    ../../sun4/io/pcicfg.c:580: error: passing argument 3 of 'pci_cap_put' makes integer from pointer without a cast
    ../../common/sys/pci_cap.h:113: note: expected 'uint32_t' but argument is of type 'void *'
    ../../sun4/io/pcicfg.c:582: error: passing argument 3 of 'pci_cap_get' makes integer from pointer without a cast
    ../../common/sys/pci_cap.h:110: note: expected 'uint32_t' but argument is of type 'void *'
    ../../sun4/io/pcicfg.c:587: error: passing argument 3 of 'pci_cap_get' makes integer from pointer without a cast
    ../../common/sys/pci_cap.h:110: note: expected 'uint32_t' but argument is of type 'void *'
    ../../sun4/io/pcicfg.c:593: error: passing argument 3 of 'pci_cap_get' makes integer from pointer without a cast
    ../../common/sys/pci_cap.h:110: note: expected 'uint32_t' but argument is of type 'void *'
    ../../sun4/io/pcicfg.c:597: error: passing argument 3 of 'pci_cap_get' makes integer from pointer without a cast
    ../../common/sys/pci_cap.h:110: note: expected 'uint32_t' but argument is of type 'void *'
    ../../sun4/io/pcicfg.c: In function 'pcicfg_is_chassis':
    ../../sun4/io/pcicfg.c:617: error: passing argument 3 of 'pci_cap_get' makes integer from pointer without a cast
    ../../common/sys/pci_cap.h:110: note: expected 'uint32_t' but argument is of type 'void *'
    ../../sun4/io/pcicfg.c: In function 'pcicfg_pcie_port_type':
    ../../sun4/io/pcicfg.c:668: error: passing argument 3 of 'pci_cap_get' makes integer from pointer without a cast
    ../../common/sys/pci_cap.h:110: note: expected 'uint32_t' but argument is of type 'void *'
    ../../sun4/io/pcicfg.c: In function 'pcicfg_set_standard_props':
    ../../sun4/io/pcicfg.c:3538: error: passing argument 3 of 'pci_cap_get' makes integer from pointer without a cast
    ../../common/sys/pci_cap.h:110: note: expected 'uint32_t' but argument is of type 'void *'
    ../../sun4/io/pcicfg.c:3542: error: passing argument 3 of 'pci_cap_get' makes integer from pointer without a cast
    ../../common/sys/pci_cap.h:110: note: expected 'uint32_t' but argument is of type 'void *'
    ../../sun4/io/pcicfg.c: In function 'pcicfg_disable_bridge_probe_err':
    ../../sun4/io/pcicfg.c:3980: error: passing argument 3 of 'pci_cap_get' makes integer from pointer without a cast
    ../../common/sys/pci_cap.h:110: note: expected 'uint32_t' but argument is of type 'void *'
    ../../sun4/io/pcicfg.c:3986: error: passing argument 3 of 'pci_cap_put' makes integer from pointer without a cast
    ../../common/sys/pci_cap.h:113: note: expected 'uint32_t' but argument is of type 'void *'
    ../../sun4/io/pcicfg.c: In function 'pcicfg_fcode_probe':
    ../../sun4/io/pcicfg.c:4638: error: passing argument 3 of 'ddi_prop_lookup_string' makes integer from pointer without a cast
    ../../common/sys/sunddi.h:762: note: expected 'uint_t' but argument is of type 'void *'

Actions #1

Updated by Electric Monk about 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 3150e93da4db1a6b51b0046c3b48412cb427137c

commit  3150e93da4db1a6b51b0046c3b48412cb427137c
Author: Toomas Soome <tsoome@me.com>
Date:   2020-04-27T16:31:51.000Z

    12555 pcicfg: NULL pointer errors
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: Yuri Pankov <ypankov@fastmail.com>
    Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF