Project

General

Profile

Bug #12565

max1617: NULL pointer errors

Added by Toomas Soome 3 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build errors with NULL pointer:

    ../../sun4u/io/i2c/clients/max1617.c: In function 'max1617_do_attach':
    ../../sun4u/io/i2c/clients/max1617.c:194: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast
    ../../common/sys/sunddi.h:1571: note: expected 'int' but argument is of type 'void *'
    ../../sun4u/io/i2c/clients/max1617.c:207: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast
    ../../common/sys/sunddi.h:1571: note: expected 'int' but argument is of type 'void *'
    /code/illumos-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/smatch: ../../sun4u/io/i2c/clients/max1617.c:197 max1617_do_attach() warn: inconsistent indenting


Related issues

Related to illumos gate - Bug #12814: CCVERBOSE flag in CFLAGS is redundant and not neededIn Progress

Actions

History

#1

Updated by Toomas Soome about 1 month ago

  • Related to Bug #12814: CCVERBOSE flag in CFLAGS is redundant and not needed added
#2

Updated by Electric Monk about 1 month ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 01e7b7f0889d1871183449cbcbc41e1f90f40610

commit  01e7b7f0889d1871183449cbcbc41e1f90f40610
Author: Toomas Soome <tsoome@me.com>
Date:   2020-06-03T17:27:29.000Z

    12565 max1617: NULL pointer errors
    Reviewed by: Robert Mustacchi <rm@fingolfin.org>
    Reviewed by: Yuri Pankov <ypankov@tintri.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF