Project

General

Profile

Bug #12576

pcf8591: NULL pointer errors

Added by Toomas Soome 3 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build errors with NULL pointer:

    ../../sun4u/io/i2c/clients/pcf8591.c: In function 'pcf8591_ioctl':
    ../../sun4u/io/i2c/clients/pcf8591.c:239: error: comparison between pointer and integer
    ../../sun4u/io/i2c/clients/pcf8591.c: In function 'pcf8591_do_attach':
    ../../sun4u/io/i2c/clients/pcf8591.c:488: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast
    ../../common/sys/sunddi.h:1571: note: expected 'int' but argument is of type 'void *'

Testing done: build/install/boot

Related issues

Related to illumos gate - Bug #12814: CCVERBOSE flag in CFLAGS is redundant and not neededIn Progress

Actions

History

#1

Updated by Toomas Soome about 1 month ago

  • Related to Bug #12814: CCVERBOSE flag in CFLAGS is redundant and not needed added
#2

Updated by Toomas Soome about 1 month ago

  • Description updated (diff)
#3

Updated by Electric Monk about 1 month ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit a4ee597764d8f5774053526bb200ad03100a4ff0

commit  a4ee597764d8f5774053526bb200ad03100a4ff0
Author: Toomas Soome <tsoome@me.com>
Date:   2020-06-05T20:26:50.000Z

    12576 pcf8591: NULL pointer errors
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF