Project

General

Profile

Bug #12577

px: NULL pointer errors

Added by Toomas Soome 3 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors with NULL pointer:

    ../../sun4v/io/px/px_tools_4v.c: In function 'pxtool_phys_access':
    ../../sun4v/io/px/px_tools_4v.c:187: error: passing argument 4 of 'hv_hpriv' makes integer from pointer without a cast
    ../../sun4v/io/px/px_lib4v.h:219: note: expected 'uint64_t' but argument is of type 'void *'

    ../../sun4v/io/px/px_err.c: In function 'px_err_fill_pfd':
    ../../sun4v/io/px/px_err.c:154: error: assignment makes integer from pointer without a cast
    /code/illumos-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/smatch: ../../sun4v/io/px/px_err.c:839 px_mmu_handle_lookup() warn: should this be a bitwise op?

    ../../sun4v/io/px/px_lib4v.c: In function 'px_lib_log_safeacc_err':
    ../../sun4v/io/px/px_lib4v.c:1689: error: passing argument 4 of 'px_rp_en_q' makes integer from pointer without a cast
    ../../sun4/io/px/px_fm.h:131: note: expected 'uint16_t' but argument is of type 'void *'

    ../../sun4u/io/px/px_err.c:619: error: initialization makes integer from pointer without a cast
    ../../sun4u/io/px/px_err.c:620: error: initialization makes integer from pointer without a cast
    ../../sun4u/io/px/px_err.c:621: error: initialization makes integer from pointer without a cast
    ../../sun4u/io/px/px_err.c:622: error: initialization makes integer from pointer without a cast
    ../../sun4u/io/px/px_err.c:623: error: initialization makes integer from pointer without a cast
    ../../sun4u/io/px/px_err.c:624: error: initialization makes integer from pointer without a cast
    ../../sun4u/io/px/px_err.c: In function 'px_err_reg_enable':
    ../../sun4u/io/px/px_err.c:740: error: comparison between pointer and integer
    ../../sun4u/io/px/px_err.c:761: error: comparison between pointer and integer
    ../../sun4u/io/px/px_err.c: In function 'px_err_reg_disable':
    ../../sun4u/io/px/px_err.c:773: error: comparison between pointer and integer
    ../../sun4u/io/px/px_err.c: In function 'px_err_mmu_tfar_tfsr_send_ereport':
    ../../sun4u/io/px/px_err.c:1725: error: passing argument 3 of 'px_rp_en_q' makes integer from pointer without a cast
    ../../sun4/io/px/px_fm.h:131: note: expected 'uint32_t' but argument is of type 'void *'
    ../../sun4u/io/px/px_err.c: In function 'px_err_mmu_rbne_handle':
    ../../sun4u/io/px/px_err.c:1797: error: passing argument 4 of 'pf_hdl_lookup' makes integer from pointer without a cast
    ../../common/sys/pcie_impl.h:649: note: expected 'uint64_t' but argument is of type 'void *'
    ../../sun4u/io/px/px_err.c: In function 'px_err_mmu_tfa_handle':
    ../../sun4u/io/px/px_err.c:1828: error: passing argument 4 of 'pf_hdl_lookup' makes integer from pointer without a cast
    ../../common/sys/pcie_impl.h:649: note: expected 'uint64_t' but argument is of type 'void *'

    ../../sun4/io/px/px_fm.c: In function 'px_fm_callback':
    ../../sun4/io/px/px_fm.c:332: error: assignment makes integer from pointer without a cast
    ../../sun4/io/px/px_fm.c: In function 'px_err_fabric_intr':
    ../../sun4/io/px/px_fm.c:451: error: passing argument 3 of 'px_rp_en_q' makes integer from pointer without a cast
    ../../sun4/io/px/px_fm.h:131: note: expected 'uint32_t' but argument is of type 'void *'
    ../../sun4/io/px/px_fm.c:451: error: passing argument 4 of 'px_rp_en_q' makes integer from pointer without a cast
    ../../sun4/io/px/px_fm.h:131: note: expected 'uint16_t' but argument is of type 'void *'
    ../../sun4/io/px/px_fm.c: In function 'px_get_pfd':
    ../../sun4/io/px/px_fm.c:742: error: assignment makes integer from pointer without a cast
    ../../sun4/io/px/px_fm.c: In function 'px_err_pio_hdl_check':
    ../../sun4/io/px/px_fm.c:893: error: comparison between pointer and integer
    ../../sun4/io/px/px_fm.c: In function 'px_err_dma_hdl_check':
    ../../sun4/io/px/px_fm.c:930: error: comparison between pointer and integer

    ../../sun4/io/px/px_tools.c: In function 'pxtool_get_phys_addr':
    ../../sun4/io/px/px_tools.c:491: error: return makes integer from pointer without a cast

    ../../sun4/io/px/px_util.c: In function 'px_init_child':
    ../../sun4/io/px/px_util.c:410: error: initialization makes integer from pointer without a cast

    ../../sun4/io/px/px.c: In function 'px_attach':
    ../../sun4/io/px/px.c:229: error: initialization makes integer from pointer without a cast
    ../../sun4/io/px/px.c: In function 'px_detach':
    ../../sun4/io/px/px.c:524: error: assignment makes integer from pointer without a cast

    ../../sun4u/io/px/px_lib4u.c: In function 'oberon_set_cb':
    ../../sun4u/io/px/px_lib4u.c:1419: error: comparison between pointer and integer
    ../../sun4u/io/px/px_lib4u.c: In function 'px_lib_clr_errs':
    ../../sun4u/io/px/px_lib4u.c:1562: error: passing argument 4 of 'px_rp_en_q' makes integer from pointer without a cast
    ../../sun4/io/px/px_fm.h:131: note: expected 'uint16_t' but argument is of type 'void *'

Testing done: build/install/boot


Related issues

Related to illumos gate - Bug #12814: CCVERBOSE flag in CFLAGS is redundant and not neededIn Progress

Actions

History

#1

Updated by Toomas Soome about 1 month ago

  • Description updated (diff)
  • Gerrit CR set to 558
#2

Updated by Toomas Soome about 1 month ago

  • Related to Bug #12814: CCVERBOSE flag in CFLAGS is redundant and not needed added
#3

Updated by Electric Monk about 1 month ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit e214b19eaa16fec1fa60a97227778103f598336f

commit  e214b19eaa16fec1fa60a97227778103f598336f
Author: Toomas Soome <tsoome@me.com>
Date:   2020-06-08T18:24:25.000Z

    12577 px: NULL pointer errors
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Reviewed by: Gary Mills <gary_mills@fastmail.fm>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF