Project

General

Profile

Actions

Bug #12621

closed

tazmo: smatch and NULL pointer errors

Added by Toomas Soome about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors on SPARC with NULL pointer:

    ../../../sun4u/tazmo/io/envctrl.c: In function 'envctrl_attach':
    ../../../sun4u/tazmo/io/envctrl.c:523: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast
    ../../../common/sys/sunddi.h:1571: note: expected 'int' but argument is of type 'void *'
    ../../../sun4u/tazmo/io/envctrl.c: In function 'envctrl_init_bus':
    ../../../sun4u/tazmo/io/envctrl.c:1452: error: initialization makes integer from pointer without a cast
    ../../../sun4u/tazmo/io/envctrl.c: In function 'envctrl_get_sys_temperatures':
    ../../../sun4u/tazmo/io/envctrl.c:1978: error: initialization makes integer from pointer without a cast
    /code/illumos-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/smatch: ../../../sun4u/tazmo/io/envctrl.c:1893 envctrl_get_lm75_temp() warn: inconsistent indenting
    /code/illumos-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/smatch: ../../../sun4u/tazmo/io/envctrl.c:2053 envctrl_get_sys_temperatures() warn: inconsistent indenting
    /code/illumos-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/smatch: ../../../sun4u/tazmo/io/envctrl.c:2114 envctrl_get_sys_temperatures() warn: inconsistent indenting

Actions #1

Updated by Electric Monk about 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit eb6b10e69fa5ba733da194d3ad71a0e63338be29

commit  eb6b10e69fa5ba733da194d3ad71a0e63338be29
Author: Toomas Soome <tsoome@me.com>
Date:   2020-05-10T06:47:35.000Z

    12621 tazmo: smatch and NULL pointer errors
    Reviewed by: Gergő Doma <domag02@gmail.com>
    Reviewed by: C Fraire <cfraire@me.com>
    Reviewed by: Patrick Mooney <pmooney@pfmooney.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions

Also available in: Atom PDF