Project

General

Profile

Actions

Bug #12631

closed

sunfire: smatch and NULL pointer errors

Added by Toomas Soome about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors on SPARC with NULL pointers:

    /code/illumos-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/smatch: ../../../sun4u/sunfire/io/sysctrl_quiesce.c:580 sysctrl_resume() error: unchecked function return 'tod_ops.tod_set_watchdog_timer'
    /code/illumos-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/smatch: ../../../sun4u/sunfire/io/sysctrl_quiesce.c:734 sysctrl_suspend() error: unchecked function return 'tod_ops.tod_clear_watchdog_timer'

    ../../../sun4u/sunfire/io/sysctrl.c: In function 'sysctrl_attach':
    ../../../sun4u/sunfire/io/sysctrl.c:809: error: cast from pointer to integer of different size [-Wpointer-to-int-cast]

    ../../../sun4u/sunfire/io/fhc.c: In function 'cpu_on_board':
    ../../../sun4u/sunfire/io/fhc.c:2387: error: comparison between pointer and integer
    ../../../sun4u/sunfire/io/fhc.c:2388: error: comparison between pointer and integer

    ../../../sun4u/sunfire/io/ac.c: In function 'ac_add_picN_kstats':
    ../../../sun4u/sunfire/io/ac.c:921: error: passing argument 7 of 'kstat_create' makes integer from pointer without a cast
    ../../../common/sys/kstat.h:793: note: expected 'uchar_t' but argument is of type 'void *'

Actions #1

Updated by Electric Monk about 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 50ed1c1e61e07032076ff0041b06b604754d190c

commit  50ed1c1e61e07032076ff0041b06b604754d190c
Author: Toomas Soome <tsoome@me.com>
Date:   2020-05-10T07:43:03.000Z

    12631 sunfire: smatch and NULL pointer errors
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions

Also available in: Atom PDF