Project

General

Profile

Actions

Feature #12635

closed

Allow for '-o feature@<feature>=disabled' on the command line

Added by Jason King about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Port from OpenZFS. Some additional features to port utilize this cmdline feature for testing, so it seems reasonable to port this as a prerequisite:

From the OpenZFS change:

Sometimes it is desirable to specifically disable one or several
features directly on the 'zpool create' command line.

$ zpool create -o feature@<feature>=disabled ...

Original-patch-by: Turbo Fredriksson <turbo@bayour.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes #3460
Closes #5142
Closes #5324

Related issues

Related to illumos gate - Bug #12636: Prevent unnecessary resilver restartsClosedJason King

Actions
Actions #1

Updated by Jason King about 2 years ago

  • Related to Bug #12636: Prevent unnecessary resilver restarts added
Actions #2

Updated by Jason King about 2 years ago

For testing, since this change merely exposes existing functionality of the zfs ioctl(2) interface (rather than adding new functionality to the zfs itself) I ran the zpool create tests (/opt/zfs-tests/tests/functional/cli_root/zpool_create) -- which included changes to an existing test, as well as a new test. All passed.

Actions #3

Updated by Electric Monk about 2 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit f343451914d0efaf2d6fc84d8818a16246b223dc

commit  f343451914d0efaf2d6fc84d8818a16246b223dc
Author: LOLi <loli10K@users.noreply.github.com>
Date:   2020-04-30T17:29:18.000Z

    12635 Allow for '-o feature@<feature>=disabled' on the command line
    Portions contributed by: Turbo Fredriksson <turbo@bayour.com>
    Portions contributed by: Jason King <jason.king@joyent.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF