Project

General

Profile

Bug #12640

clean up sysinfo(2)

Added by Joshua M. Clulow 2 months ago. Updated about 2 months ago.

Status:
New
Priority:
Normal
Category:
manpage - manual pages
Start date:
Due date:
% Done:

0%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

The sysinfo(2) manual page has some busted markup. First, warnings from the usual checks:

Man page format/spelling:
mandoc: usr/src/man/man2/sysinfo.2:11:2: WARNING: skipping paragraph macro: PP after SH
mandoc: usr/src/man/man2/sysinfo.2:19:2: WARNING: skipping paragraph macro: PP after SH
mandoc: usr/src/man/man2/sysinfo.2:302:2: WARNING: skipping paragraph macro: PP after SH
mandoc: usr/src/man/man2/sysinfo.2:313:2: WARNING: skipping paragraph macro: PP after SH
mandoc: usr/src/man/man2/sysinfo.2:345:2: WARNING: skipping paragraph macro: PP after SH
mandoc: usr/src/man/man2/sysinfo.2:356:2: WARNING: skipping paragraph macro: PP after SH

And, as Andy noted in a recent review, a bunch of headings have duplicate \fB and \fR pairs.

History

#1

Updated by Ovidiu-Dan Bogat 2 months ago

Hi.

I've cleaned up the sysinfo.2 man page, created a webrev and deployed it on the web for review.

https://ovidiu.at/illumos/bug12640/

Please advise on how to proceed further (on my part) as this would be my first patch @ illumos.

Kind regards,
Ovidiu-Dan Bogat

#2

Updated by Joshua M. Clulow about 2 months ago

Hi! Sorry, I've had a lot of e-mail in the last fortnight and I'm just getting back to this now.

First, thanks for taking a look at this! The guide to follow for contributing a change is up at: https://illumos.org/docs/contributing/

Since you've already got a webrev for the change you'd like to make, you're up to the step where you're seeking code review: https://illumos.org/docs/contributing/#code-review

It's probably best to sign up for the "developer" mailing list and post a review request there: https://illumos.topicbox.com/groups/developer -- you can see lots of existing review request mail in the archive if you want to see an example.

Let me know if you need more assistance!

#3

Updated by Joshua M. Clulow about 2 months ago

  • Assignee set to Ovidiu-Dan Bogat

Also available in: Atom PDF