Project

General

Profile

Actions

Bug #12652

closed

platsvc: smatch and NULL pointer errors

Added by Toomas Soome about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
driver - device drivers
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors on SPARC with NULL pointers:

    ../../sun4v/io/mdeg.c: In function 'mdeg_find_start_node':
    ../../sun4v/io/mdeg.c:661: error: passing argument 2 of 'md_scan_dag' makes integer from pointer without a cast
    ../../common/sys/mdesc.h:163: note: expected 'mde_cookie_t' but argument is of type 'void *'
    ../../sun4v/io/mdeg.c:667: error: passing argument 2 of 'md_scan_dag' makes integer from pointer without a cast
    ../../common/sys/mdesc.h:163: note: expected 'mde_cookie_t' but argument is of type 'void *'
    /code/illumos-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/smatch: ../../sun4v/io/mdeg.c:337 mdeg_notify_client_reg() error: unchecked function return '(*clnt->cb)'
    /code/illumos-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/smatch: ../../sun4v/io/mdeg.c:390 mdeg_notify_client_reg() error: unchecked function return '(*clnt->cb)'
    /code/illumos-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/smatch: ../../sun4v/io/mdeg.c:454 mdeg_register() warn: inconsistent indenting
    /code/illumos-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/smatch: ../../sun4v/io/mdeg.c:489 mdeg_unregister() warn: inconsistent indenting
    /code/illumos-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/smatch: ../../sun4v/io/mdeg.c:605 mdeg_notify_client() error: unchecked function return '(*clnt->cb)'
    /code/illumos-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/smatch: ../../sun4v/io/mdeg.c:637 mdeg_notify_client() error: unchecked function return '(*clnt->cb)'

Actions #1

Updated by Electric Monk about 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit a5efd12c64532eac05eb5a4b6901396be06125bf

commit  a5efd12c64532eac05eb5a4b6901396be06125bf
Author: Toomas Soome <tsoome@me.com>
Date:   2020-05-10T08:03:09.000Z

    12652 platsvc: smatch and NULL pointer errors
    Reviewed by: C Fraire <cfraire@me.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions

Also available in: Atom PDF