Project

General

Profile

Actions

Bug #12657

closed

opl: NULL pointer errors

Added by Toomas Soome about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build errors on SPARC with NULL pointers:

    ../../../sun4u/opl/io/mc-opl.c: In function 'mc_ioctl':
    ../../../sun4u/opl/io/mc-opl.c:615: error: comparison between pointer and integer

    ../../../sun4u/opl/io/oplmsu/oplmsu.c: In function 'oplmsu_close':
    ../../../sun4u/opl/io/oplmsu/oplmsu.c:663: error: assignment makes integer from pointer without a cast

    ../../../sun4u/opl/io/drmach.c: In function 'drmach_node_ddi_get_dnode':
    ../../../sun4u/opl/io/drmach.c:738: error: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    ../../../sun4u/opl/io/drmach.c: In function 'drmach_copy_rename':
    ../../../sun4u/opl/io/drmach.c:4045: error: comparison between pointer and integer

    cc1: warnings being treated as errors
    ../../../sun4u/opl/io/pcicmu/pcmu_counters.c: In function 'pcmu_create_picN_kstat':
    ../../../sun4u/opl/io/pcicmu/pcmu_counters.c:98: error: passing argument 7 of 'kstat_create' makes integer from pointer without a cast
    ../../../common/sys/kstat.h:793: note: expected 'uchar_t' but argument is of type 'void *'

    cc1: warnings being treated as errors
    ../../../sun4u/opl/io/oplkmdrv.c: In function 'okm_attach':
    ../../../sun4u/opl/io/oplkmdrv.c:244: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast
    ../../../common/sys/sunddi.h:1577: note: expected 'int' but argument is of type 'void *'

    ../../../sun4u/opl/io/dm2s.c: In function 'dm2s_attach':
    ../../../sun4u/opl/io/dm2s.c:299: error: passing argument 6 of 'ddi_create_minor_node' makes integer from pointer without a cast
    ../../../common/sys/sunddi.h:1577: note: expected 'int' but argument is of type 'void *'

Actions #1

Updated by Electric Monk about 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit bbe1232ef8d8a5a776f6afde8466f315c8143dd4

commit  bbe1232ef8d8a5a776f6afde8466f315c8143dd4
Author: Toomas Soome <tsoome@me.com>
Date:   2020-05-08T14:13:02.000Z

    12657 opl: NULL pointer errors
    Reviewed by: Peter Tribble <peter.tribble@gmail.com>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions

Also available in: Atom PDF