Project

General

Profile

Actions

Bug #12662

closed

smbios(1M) interprets jedec IDs incorrectly

Added by Robert Mustacchi about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Category:
cmd - userland programs
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

While on a system with SMBIOS 3.2 support, I noticed that we actually had a Jedec ID for the memory module in smbios(1M); however, it wasn't reporting it as a string. I manually decoded it with libjedec and found that we did actually have the right information; however, the problem was that the way that smbios(1M) was transforming the data into continuations was off. I had misinterpreted the spec and had basically swapped the continuation and vendor indicators. This fixes this up and indicates the ID as the combination. So, for example, you used to see:

smbios -i 52
ID    SIZE TYPE
52    159  SMB_TYPE_MEMDEVICE (type 17) (memory device)

...
  Module Manufacturer ID: 0x2c80
...

Instead, you now see (and for all other Jedec derived fields):

smbios -i 52
ID    SIZE TYPE
52    159  SMB_TYPE_MEMDEVICE (type 17) (memory device)

...
  Module Manufacturer ID: Bank: 0x1 Vendor: 0x2c (Micron Technology)
...

I tested this manually on the system and also verified that the smbios and libjedec test suites were still good.

Actions #1

Updated by Electric Monk about 2 years ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

git commit 9f9cceb6f1158940244c35cecdbc93f9a386a4b8

commit  9f9cceb6f1158940244c35cecdbc93f9a386a4b8
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   2020-05-01T01:53:20.000Z

    12662 smbios(1M) interprets jedec IDs incorrectly
    12664 fix smbios memory technology operating mode capabilities
    Reviewed by: Yuri Pankov <ypankov@fastmail.com>
    Reviewed by: Toomas Soome <toomas@me.com>
    Reviewed by: Paul Winder <paul@winders.demon.co.uk>
    Reviewed by: Gergo Doma <domag02@gmail.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions

Also available in: Atom PDF