hcksum routines are too verbose
Upstreaming OS-6761 for bhyve:
hcksum_retreivefunctions feature special handling for
M_MULTIDATAmblks which are no longer used by anything in the gate. Removing that logic would make their calls less verbose and marginally decrease the amount of work they must undertake.
It turns out that some closed drivers that we ship make use of those old functions so they can't be changed. Switching in-gate consumers to the (more recent) mac_hcksum_* counterparts is an adequate substitute.
I tested the fix for this (and OS-6762) with workloads running with and without VLANs between instances. Additionally, I floated the expected patch for OS-6701 over the top to further test the mac_hcksum_clone function, as it's essential to that fix. It worked as desired, too.
Updated by Patrick Mooney over 2 years ago
I do not have access to environments with the NICs which had their drivers modified by this change. I'm relying on the fact that the changes to those callsites are limited in scope and well defined. An error in this change would likely be caught by the compiler as a type mismatch.
Updated by Electric Monk over 2 years ago
- Status changed from In Progress to Closed
- % Done changed from 0 to 100
commit ec71f88e58593e3077f03588d3c38e6cbd4e8c1a Author: Patrick Mooney <email@example.com> Date: 2020-05-11T02:35:52.000Z 12671 hcksum routines are too verbose 12672 want mac_hcksum_clone function Reviewed by: Robert Mustacchi <firstname.lastname@example.org> Reviewed by: Ryan Zezeski <email@example.com> Approved by: Robert Mustacchi <firstname.lastname@example.org>