Project

General

Profile

Feature #12671

hcksum routines are too verbose

Added by Patrick Mooney 9 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Patrick Mooney
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
bhyve
Gerrit CR:

Description

Upstreaming OS-6761 for bhyve:

The hcksum_assoc and hcksum_retreive functions feature special handling for M_MULTIDATA mblks which are no longer used by anything in the gate. Removing that logic would make their calls less verbose and marginally decrease the amount of work they must undertake.

It turns out that some closed drivers that we ship make use of those old functions so they can't be changed. Switching in-gate consumers to the (more recent) mac_hcksum_* counterparts is an adequate substitute.

I tested the fix for this (and OS-6762) with workloads running with and without VLANs between instances. Additionally, I floated the expected patch for OS-6701 over the top to further test the mac_hcksum_clone function, as it's essential to that fix. It worked as desired, too.

Related issues

Related to illumos gate - Bug #12739: gld module missing dep on mac after 12671ClosedRobert Mustacchi

Actions
#1

Updated by Patrick Mooney 9 months ago

I do not have access to environments with the NICs which had their drivers modified by this change. I'm relying on the fact that the changes to those callsites are limited in scope and well defined. An error in this change would likely be caught by the compiler as a type mismatch.

#2

Updated by Electric Monk 9 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit ec71f88e58593e3077f03588d3c38e6cbd4e8c1a

commit  ec71f88e58593e3077f03588d3c38e6cbd4e8c1a
Author: Patrick Mooney <pmooney@pfmooney.com>
Date:   2020-05-11T02:35:52.000Z

    12671 hcksum routines are too verbose
    12672 want mac_hcksum_clone function
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Ryan Zezeski <rpz@joyent.com>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

#3

Updated by Robert Mustacchi 9 months ago

  • Related to Bug #12739: gld module missing dep on mac after 12671 added

Also available in: Atom PDF