Project

General

Profile

Actions

Feature #12671

closed

hcksum routines are too verbose

Added by Patrick Mooney over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
kernel
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
bhyve
Gerrit CR:
External Bug:

Description

Upstreaming OS-6761 for bhyve:

The hcksum_assoc and hcksum_retreive functions feature special handling for M_MULTIDATA mblks which are no longer used by anything in the gate. Removing that logic would make their calls less verbose and marginally decrease the amount of work they must undertake.

It turns out that some closed drivers that we ship make use of those old functions so they can't be changed. Switching in-gate consumers to the (more recent) mac_hcksum_* counterparts is an adequate substitute.

I tested the fix for this (and OS-6762) with workloads running with and without VLANs between instances. Additionally, I floated the expected patch for OS-6701 over the top to further test the mac_hcksum_clone function, as it's essential to that fix. It worked as desired, too.


Related issues

Related to illumos gate - Bug #12739: gld module missing dep on mac after 12671ClosedRobert Mustacchi

Actions
Actions

Also available in: Atom PDF