Project

General

Profile

Bug #12684

Inject zinject a percentage amount of dev errs

Added by Jason King 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
zfs - Zettabyte File System
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Port of OpenZFS change:

commit 0241e491a08ffa471a08ceaa0b0943999d775cbe
Author: Don Brady <don.brady@intel.com>
Date:   Fri Jun 16 18:21:11 2017 -0600

    Inject zinject(8) a percentage amount of dev errs

    In the original form of device error injection, it was an all or nothing
    situation.  To help simulate intermittent error conditions, you can now
    specify a real number percentage value. This is also very useful for our
    ZFS fault diagnosis testing and for injecting intermittent errors during
    load testing.

    Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
    Signed-off-by: Don Brady <don.brady@intel.com>
    Closes #6227

Some zfs-tests in OpenZFS make use of this, so it'd be helpful to have this as well to assist in porting future OpenZFS changes.


Related issues

Blocks illumos gate - Bug #12636: Prevent unnecessary resilver restartsClosed

Actions

History

#1

Updated by Jason King 2 months ago

  • Blocks Bug #12636: Prevent unnecessary resilver restarts added
#2

Updated by Jason King 2 months ago

  • Subject changed from Inject zinject a percentage amount of dev errs to Inject zinject a percentage amount of dev errs
#3

Updated by Jason King 2 months ago

To test, I ran the zfs test suite (some of the tests utilize zinject). All of the failures were known existing issues.

#4

Updated by Jason King 2 months ago

I also tested this change in conjunction with #12636 as that test makes specific use of the functionality in this change (and was the reason for porting this change). The new test introduced with #12636 now passes (prior to this, that new test would fail because zinject was exiting with an error due to incorrect usage).

#5

Updated by Electric Monk 2 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit b853d39ade4a504f3447f996dbf5dd985f0236bc

commit  b853d39ade4a504f3447f996dbf5dd985f0236bc
Author: Don Brady <don.brady@intel.com>
Date:   2020-05-05T21:48:28.000Z

    12684 Inject zinject a percentage amount of dev errs
    Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
    Portions contributed by: Jason King <jason.king@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

#6

Updated by Joshua M. Clulow about 2 months ago

To clarify, this changes the -f argument to zinject that controls the frequency of injected errors; it used to take an integer percentage and will now accept a fractional value expressed in decimal.

Also available in: Atom PDF