illumos gate

With GCC9, compiling some of ON gives:

 libucb: mismatch in argument 1 type of built-in function '__builtin_alloca'; expected 'unsigned int'

The problem is that "size_t" for 32-bit C in ucbhead/sys/types.h is defined as "ulong_t". This doesn't occur in other situations.

As the extern declaration of the builtin is completely unecessary under GCC 4 onwards at least, the simplest solution is to remove it from string.h

John Levon wrote:

With GCC9, compiling some of ON gives:

[...]

The problem is that "size_t" for 32-bit C in ucbhead/sys/types.h is defined as "ulong_t". This doesn't occur in other situations.

As the extern declaration of the builtin is completely unecessary under GCC 4 onwards at least, the simplest solution is to remove it from string.h

The issue is reported for: libucb, libtermcap, libdbm, libcurses, librpcsoc and vipw.

I spot tested this under GCC4, 7, and 9, as well doing a nightly on a system installed with this new string.h