Project

General

Profile

Actions

Bug #12710

closed

loader: vdev_read() can corrupt memory

Added by Toomas Soome about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

When reading less than sector size but from sector boundary, the vdev_read() will read full sector into the provided buffer and therefore corrupting memory past buffer end.

Tested by user affected by this issue. Also build/install/boot on illumos.

Actions #1

Updated by Toomas Soome about 2 years ago

  • Description updated (diff)
Actions #2

Updated by Electric Monk about 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit cee39f3ff96ecf06e603339642e5393b7c1738e8

commit  cee39f3ff96ecf06e603339642e5393b7c1738e8
Author: Toomas Soome <tsoome@me.com>
Date:   2020-05-11T05:07:15.000Z

    12710 loader: vdev_read() can corrupt memory
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Approved by: Robert Mustacchi <rm@fingolfin.org>

Actions

Also available in: Atom PDF